[Intel-xe] [PATCH 2/2] drm/xe: Drop xe_mmio_write64()

[Lucas De Marchi]

On Tue, Aug 22, 2023 at 02:51:55PM +0000, Jose Souza wrote:
>On Tue, 2023-08-22 at 07:15 -0700, Lucas De Marchi wrote:
>> On Tue, Aug 22, 2023 at 07:12:48AM -0700, Lucas De Marchi wrote:
>> > On Mon, Aug 21, 2023 at 04:43:24PM -0700, Matt Roper wrote:
>> > > The only possible 64-bit register writes in the driver come from the
>> > > highly questionable MMIO ioctl.  That ioctl's register write support
>> > > only operates for userspace running as root and cannot be used by any
>> > > real userspace; it exists solely to support the "xe_reg" debug tool in
>> >
>> > mesa also uses it for some operations to avoid the extra latency of
>> > setting up a bb. Have we confirmed none of those accesses are 64b?
>>
>> but you are actually only removing the write side, so this is fine and
>> the rest of my comment can be ignored. Sorry for the noise.
>
>Maybe add something to the uAPI about 64bits writes not being supported? not everyone is going to read Xe KMD source code to figure it is not
>supported, with that both patches are: Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

it would still return an error (-EOPNOTSUPP) due to the default case
handling, so it's not needed to read the source :), just correctly
handle errors :)

Lucas De Marchi