[Intel-xe] [PATCH] fixup! drm/xe/pvc: Use fast copy engines as migrate engine on PVC

[Mauro Carvalho Chehab]

On Tue, 29 Aug 2023 01:04:29 -0700
Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com> wrote:

> Update Makefile to generate OOB header file for xe_migrate.c
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> ---
>  drivers/gpu/drm/xe/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index 550cdfed729e..78365e14f0d3 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -37,7 +37,7 @@ quiet_cmd_wa_oob = GEN     $(notdir $(generated_oob))
>  $(generated_oob) &: $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
>  	$(call cmd,wa_oob)
>  
> -$(obj)/xe_guc.o $(obj)/xe_wa.o $(obj)/xe_ring_ops.o $(obj)/xe_vm.o: $(generated_oob)
> +$(obj)/xe_guc.o $(obj)/xe_wa.o $(obj)/xe_ring_ops.o $(obj)/xe_vm.o $(obj)/xe_migrate.o: $(generated_oob)
>  
>  # Please keep these build lists sorted!
>  
Looks good to me. I would prefer to keep the targets that depends on
$(generated_oob) in alphabetic order.

With or without such change:

Reviewed-by: Mauro Carvalho Chehab <mchehab at kernel.org>