[Intel-xe] [RFC PATCH] kunit: Fix test log size limit too low for some tests

David Gow davidgow at google.com
Wed Aug 30 09:23:43 UTC 2023


On Wed, 30 Aug 2023 at 15:55, Janusz Krzysztofik
<janusz.krzysztofik at linux.intel.com> wrote:
>
> Now we have memory space available to a kunit test case log exposed via
> debugfs limited to 2048 bytes, while some parametrized test cases, e.g.,
> drm_framebuffer.drm_test_framebuffer_create, need more.  For this reason,
> debugfs results from affected test cases get truncated silently, and
> external tools that rely on parsing of debugfs results can fail.
>
> Increase kunit test case log size limit to 4096 bytes.
>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
> ---

There's a patch series we're hoping to take for 6.7 which allows the
log to grow to fit whatever's written into it, which should make this
patch obsolete:
https://lore.kernel.org/linux-kselftest/20230828104111.2394344-1-rf@opensource.cirrus.com/T/

Would that work for you?

-- David

>  include/kunit/test.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index d33114097d0d0..d20eb1884edfa 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running);
>  struct kunit;
>
>  /* Size of log associated with test. */
> -#define KUNIT_LOG_SIZE 2048
> +#define KUNIT_LOG_SIZE 4096
>
>  /* Maximum size of parameter description string. */
>  #define KUNIT_PARAM_DESC_SIZE 128
> --
> 2.41.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4003 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20230830/43cb2595/attachment.bin>


More information about the Intel-xe mailing list