[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Enable scratch page when page fault is enabled (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Wed Aug 30 21:39:51 UTC 2023
== Series Details ==
Series: drm/xe: Enable scratch page when page fault is enabled (rev4)
URL : https://patchwork.freedesktop.org/series/120480/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e700ea2f248a75138759bcb443affeef4a2d1991
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b73321d3650171581209ad22bdc204681ed290c4
Author: Chang, Bruce <yu.bruce.chang at intel.com>
Date: Wed Aug 30 21:34:02 2023 +0000
drm/xe: Enable scratch page when page fault is enabled
The PVC HW has a limitation that the page fault due to invalid access
will halt the corresponding EUs. So, in order to activate the debugger,
kmd needs to setup the scratch pages to unhalt the EUs.
This feature can only be enabled if scratch flag is set per VM. So, once
EU debugger is running, the debugger umd will set the scratch flag,
otherwise, this flag should not be set. So, in regular run, this feature
will not be activated.
The idea is to bind a scratch vma if the page fault is from an
invalid access. This patch is taking advantage of null pte.
After the bind, the user app can continue to run without causing a
fatal failure or reset and stop.
In case the app will bind this scratch vma to a valid address, GPUVA
handles all of this (e.g. it will create ops to unbind the old
VMA, bind the new one).
This patch only kicks in when there is a failure for both page fault
and bind, so it should have no impact to regular code path. On
another hand, it uses actual page tables instead of special scratch
page tables, so it may not require to invalidate TLBs when doing
unbind if all upper layer page tables are still being used.
tested on new scratch igt tests which will be sent out for review.
v2: per Matt's suggestion, remove the scratch page unbind.
v3: correct error handlings.
Cc: Oak Zeng <oak.zeng at intel.com>
Cc: Brian Welty <brian.welty at intel.com>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
Cc: Stuart Summers <stuart.summers at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 4b8fbc13f29ca69fe2ce030456fab1b145bc71bc drm-intel
/mt/dim: line 50: /root/.dimrc: No such file or directory
More information about the Intel-xe
mailing list