[Intel-xe] [PATCH 2/2] drm/xe/uapi: Remove useless max_page_size
Rodrigo Vivi
rodrigo.vivi at intel.com
Wed Aug 30 21:47:15 UTC 2023
The min_page_size is useful information to ensure alignment and it is
an API actually in use. However max_page_size doesn't bring any useful
information to the userspace hence being not used at all.
So, let's remove and only bring it back if that ever gets used.
Suggested-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/xe_query.c | 3 ---
include/uapi/drm/xe_drm.h | 4 ----
2 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
index c3d396904c7b..a951205100fe 100644
--- a/drivers/gpu/drm/xe/xe_query.c
+++ b/drivers/gpu/drm/xe/xe_query.c
@@ -127,7 +127,6 @@ static int query_memory_usage(struct xe_device *xe,
usage->regions[0].mem_class = XE_MEM_REGION_CLASS_SYSMEM;
usage->regions[0].instance = 0;
usage->regions[0].min_page_size = PAGE_SIZE;
- usage->regions[0].max_page_size = PAGE_SIZE;
usage->regions[0].total_size = man->size << PAGE_SHIFT;
if (perfmon_capable())
usage->regions[0].used = ttm_resource_manager_usage(man);
@@ -143,8 +142,6 @@ static int query_memory_usage(struct xe_device *xe,
usage->regions[usage->num_regions].min_page_size =
xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K ?
SZ_64K : PAGE_SIZE;
- usage->regions[usage->num_regions].max_page_size =
- SZ_1G;
usage->regions[usage->num_regions].total_size =
man->size;
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 7c08bedbeeaf..0722dc634cb5 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -174,10 +174,6 @@ struct drm_xe_query_mem_region {
* kernel.
*/
__u32 min_page_size;
- /**
- * @max_page_size: Max page-size in bytes for this region.
- */
- __u32 max_page_size;
/**
* @total_size: The usable size in bytes for this region.
*/
--
2.41.0
More information about the Intel-xe
mailing list