[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/xe2: Add workaround 18032095049 and 16021639441

Patchwork patchwork at emeril.freedesktop.org
Wed Dec 6 10:37:27 UTC 2023


== Series Details ==

Series: drm/xe/xe2: Add workaround 18032095049 and 16021639441
URL   : https://patchwork.freedesktop.org/series/127406/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 616b5e39107d00405b35d210a2025f518d4a6b27
Author: Tejas Upadhyay <tejas.upadhyay at intel.com>
Date:   Wed Dec 6 11:16:15 2023 +0530

    drm/xe/xe2: Add workaround 18032095049 and 16021639441
    
    This workaround applies to graphics 20.04 on all engines.
    
    Workaround has three parts :
    1. Pipe flush before MI_ATOMIC - This part isn't relevant to Xe
       (at least not right now) since we don't use MI_ATOMIC anywhere
       in the kernel mode driver.
    2. Memory-based interrupt masking - Memory-based interrupt processing
       isn't supported on physical functions, only virtual functions,
       according to bspec 60352. So this is probably only relevant once
       SRIOV support lands in the driver.
    3. Disabling CSB/timestamp updates to the ghwsp and pphwsp - Workaround
       is added by this change.
    
    The CSB reports to gHWSP and ppHWSP have been discussed as part
    of a different topic on some internal threads and we've confirmed
    that neither the KMD nor the GuC firmware use those for anything,
    so disabling them is always "safe" and should have no functional
    or performance impact on system operation.  The same is true for
    the timestamp updates in the ppHWSP as well.  Given that, it might
    make sense to just combine these two workarounds into a single
    record (and single patch) and apply it on all steppings. Disabling
    the reports for RCS on higher steppings doesn't have any kind of
    negative impact and will simplify the overall situation.
    
    V3(MattR):
      - Combine WA apply same WA for all engines, no performance impact
    V2(MattR):
      - Mention detail in commit message
      - Reorder bit define
      - Improve bit naming
      - Remove workaround part which isnt relevant
    
    Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
+ /mt/dim checkpatch 9d76164e08c68a3d5d081ff7b07c15a2cadf741a drm-intel
616b5e391 drm/xe/xe2: Add workaround 18032095049 and 16021639441
-:36: WARNING:TYPO_SPELLING: 'isnt' may be misspelled - perhaps 'isn't'?
#36: 
  - Remove workaround part which isnt relevant
                                 ^^^^

total: 0 errors, 1 warnings, 0 checks, 38 lines checked




More information about the Intel-xe mailing list