[Intel-xe] ✗ CI.checkpatch: warning for Handle mmap with D3
Patchwork
patchwork at emeril.freedesktop.org
Wed Dec 6 16:28:16 UTC 2023
== Series Details ==
Series: Handle mmap with D3
URL : https://patchwork.freedesktop.org/series/127432/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 14a69294e56e6f2d275e677b7270af5fa5256fd5
Author: Badal Nilawar <badal.nilawar at intel.com>
Date: Wed Dec 6 19:04:21 2023 +0530
drm/xe/dgfx: Release mmap mappings on rpm suspend
Release all mmap mappings for all vram objects which are associated
with userfault such that, while pcie function in D3hot, any access
to memory mappings will raise a userfault.
Upon userfault, in order to access memory mappings, if graphics
function is in D3 then runtime resume of dgpu will be triggered to
transition to D0.
Previous commit has blocked the rpm but let's make sure that rpm
does not get blocked for headed cards(client's parts).
Above pagefault approach will be useful for headed cards to save the
power when display is off and there are active mmap mappings.
v2:
- Add lock dep assertion before updating vram_userfault_count (Rodrigo)
- Avoid iomem check before bo migration check as bo can migrate
to system memory (Matthew Auld)
v3:
- Apply pagefault approach for headed cards.
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Anshuman Gupta <anshuman.gupta at intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>
+ /mt/dim checkpatch 9d76164e08c68a3d5d081ff7b07c15a2cadf741a drm-intel
7377d3711 drm/xe/dgfx: Block rpm for active mmap mappings
14a69294e drm/xe/dgfx: Release mmap mappings on rpm suspend
-:83: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#83: FILE: drivers/gpu/drm/xe/xe_bo.c:1176:
+ if (INTEL_DISPLAY_ENABLED(xe) && ret == VM_FAULT_NOPAGE && bo && !bo->vram_userfault_count) {
total: 0 errors, 1 warnings, 0 checks, 178 lines checked
More information about the Intel-xe
mailing list