✗ CI.checkpatch: warning for series starting with [1/2] Revert "FIXME: drm/i915: avoid taking the uncore lock for xe"

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 7 15:05:05 UTC 2023


== Series Details ==

Series: series starting with [1/2] Revert "FIXME: drm/i915: avoid taking the uncore lock for xe"
URL   : https://patchwork.freedesktop.org/series/127494/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3d68b4e1f5ac03117f6c58c5c8770191d5a6cf52
Author: Luca Coelho <luciano.coelho at intel.com>
Date:   Thu Dec 7 15:01:06 2023 +0200

    drm/i915: handle uncore spinlock when not available
    
    The uncore code may not always be available (e.g. when we build the
    display code with Xe), so we can't always rely on having the uncore's
    spinlock.
    
    To handle this, split the spin_lock/unlock_irqsave/restore() into
    spin_lock/unlock() followed by a call to local_irq_save/restore() and
    create wrapper functions for locking and unlocking the uncore's
    spinlock.  In these functions, we have a condition check and only
    actually try to lock/unlock the spinlock when I915 is defined, and
    thus uncore is available.
    
    This keeps the ifdefs contained in these new functions and all such
    logic inside the display code.
    
    Cc: Tvrtko Ursulin <tvrto.ursulin at intel.com>
    Cc: Jani Nikula <jani.nikula at intel.com>
    Cc: Ville Syrjala <ville.syrjala at linux.intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
    Reviewed-by: Jouni Högander <jouni.hogander at intel.com>
    Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20231201100032.1367589-1-luciano.coelho@intel.com
    (cherry picked from commit dcdf1bbe82f4b2a301a3692a0b1942c3fda70644)
+ /mt/dim checkpatch 668d13abebbbc3812de86be1f8477475e1d90728 drm-intel
fa52906aa Revert "FIXME: drm/i915: avoid taking the uncore lock for xe"
-:6: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '54cbd07bd1d15cb6c8d28375dce6d6b70df6d252', maybe rebased or not pulled?
#6: 
This reverts commit 54cbd07bd1d15cb6c8d28375dce6d6b70df6d252.

total: 0 errors, 1 warnings, 0 checks, 63 lines checked
3d68b4e1f drm/i915: handle uncore spinlock when not available




More information about the Intel-xe mailing list