[PATCH v5 0/9] Intel_fb.c refactoring

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Thu Dec 7 15:10:05 UTC 2023


Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

I've noticed v2 has a a-b from Jani, seems to be missing in later versions?

Den 2023-12-07 kl. 06:22, skrev Jouni Högander:
> This patch set is refactoring intel_fb.c code to get rid of
> ifdefs. This is done by splitting i915 and Xe specific parts from
> intel_fb.c into their own source files.
>
> Some ifdefs are tackled by adding definitions into Xe compatibility
> headers.
>
> Patch 7. should be sent to intel-gfx at lists.freedesktop.org.
>
> v5:
>    - s/user_mode_cmd/mode_cmd
>    - Fix typo intel_fb vs. intel_fb_bo
> v4: Empty function instead of define
> v3:
>    - intel_fb_bo_framebuffer_fini added
>    - xe_bo_get/put and unpin moved to intel_fb_bo_framebuffer_init/fini
> v2: i915 changes are now backported
>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
>
> Jouni Högander (9):
>    Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe
>      changes"
>    fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
>    drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c
>    drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static
>    drm/i915/display: Handle invalid fb_modifier in
>      intel_fb_modifier_to_tiling
>    drm/i915/display: Split i915 specific code away from intel_fb.c
>    drm/i915/display: Add intel_fb_bo_framebuffer_fini
>    fixup! drm/xe/display: Implement display support
>    fixup! drm/xe/display: Implement display support
>
>   drivers/gpu/drm/i915/Makefile                 |   1 +
>   drivers/gpu/drm/i915/display/intel_fb.c       | 247 +++++-------------
>   drivers/gpu/drm/i915/display/intel_fb.h       |   2 +
>   drivers/gpu/drm/i915/display/intel_fb_bo.c    |  97 +++++++
>   drivers/gpu/drm/i915/display/intel_fb_bo.h    |  26 ++
>   drivers/gpu/drm/xe/Makefile                   |   1 +
>   .../compat-i915-headers/gem/i915_gem_object.h |  16 ++
>   drivers/gpu/drm/xe/display/intel_fb_bo.c      |  74 ++++++
>   drivers/gpu/drm/xe/display/intel_fb_bo.h      |  24 ++
>   9 files changed, 305 insertions(+), 183 deletions(-)
>   create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.c
>   create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.h
>   create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.c
>   create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.h
>


More information about the Intel-xe mailing list