[Intel-xe] [PATCH] drm/xe: Rename info.supports_* to info.has_*

Koby Elbaz kelbaz at habana.ai
Thu Dec 7 16:17:02 UTC 2023


On 06/12/2023 16:06, Lucas De Marchi wrote:
> On Wed, Dec 06, 2023 at 09:47:52AM -0300, Gustavo Sousa wrote:
>> Quoting Lucas De Marchi (2023-12-05 11:52:35-03:00)
>>> Rename supports_mmio_ext and supports_usm to use a has_ prefix so the
>>> flags are grouped together. This settles on just one variant for
>>> positive info matching ("has_") and one for negative ("skip_").
>>>
>>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>>
>> Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>
>
> Thanks. I will leave this out a little bit more since this has been an
> area of disagreements in the past.
>
> Rodrigo / Koby, any opinions here?
>
> Lucas De Marchi


Sounds good to me.

Reviewed-by: Koby Elbaz <kelbaz at habana.ai>



More information about the Intel-xe mailing list