✓ CI.checkpatch: success for Huge PTE and scratch page updates (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Sat Dec 9 15:42:02 UTC 2023
== Series Details ==
Series: Huge PTE and scratch page updates (rev2)
URL : https://patchwork.freedesktop.org/series/127565/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 494f8b47d8de99b3884238f69f926f000961b4f2
Author: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Date: Sat Dec 9 16:18:42 2023 +0100
drm/xe: Use NULL PTEs as scratch PTEs
Currently scratch PTEs are write-enabled and points to a single scratch
page. This has the side effect that buggy applications with out-of-bounds
memory accesses may not notice the bad access since what's written may
be read back.
Instead use NULL PTEs as scratch PTEs. These always return 0 when reading,
and writing has no effect. As a slight benefit, we can also use huge NULL
PTEs.
One drawback pointed out is that debugging may be hampered since previously
when inspecting the content of the scratch page, it might be possible to
detect writes to out-of-bound addresses and possibly also
from where the out-of-bounds address originated. However since the scratch
page-table structure is kept, it will be easy to add back the single
RW-enabled scratch page under a debug define if needed.
Also update the kerneldoc accordingly and move the function to create the
scratch page-tables from xe_pt.c to xe_pt.h since it is accessing
vm structure internals and this also makes it possible to make it static.
v2:
- Don't try to encode scratch PTEs larger than 1GiB.
- Move xe_pt_create_scratch(), Update kerneldoc.
v3:
- Rebase.
Cc: Brian Welty <brian.welty at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Acked-by: Lucas De Marchi <lucas.demarchi at intel.com> #for general direction.
Reviewed-by: Brian Welty <brian.welty at intel.com>
+ /mt/dim checkpatch 1fc141d1f445b8e5ab4ff14645b0482dd98460b9 drm-intel
fdb250436 drm/xe: Restrict huge PTEs to 1GiB
494f8b47d drm/xe: Use NULL PTEs as scratch PTEs
More information about the Intel-xe
mailing list