[PATCH 1/2] fixup! fixup! drm/xe: Introduce a new DRM driver for Intel GPUs

Lucas De Marchi lucas.demarchi at intel.com
Tue Dec 12 06:18:58 UTC 2023


On Mon, Dec 11, 2023 at 10:19:06PM -0500, Rodrigo Vivi wrote:
>---
> drivers/gpu/drm/xe/xe_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>index 260e8a6034a7..9108e1d43c38 100644
>--- a/drivers/gpu/drm/xe/xe_pci.c
>+++ b/drivers/gpu/drm/xe/xe_pci.c
>@@ -375,7 +375,6 @@ static const struct pci_device_id pciidlist[] = {
> 	XE_DG1_IDS(INTEL_VGA_DEVICE, &dg1_desc),
> 	XE_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_desc),
> 	XE_DG2_IDS(INTEL_VGA_DEVICE, &dg2_desc),
>-	XE_PVC_IDS(INTEL_VGA_DEVICE, &pvc_desc),

sorry for missing that in the previous review.

Since you are removing the only user, you will need a __maybe_unused in
pvc_desc, otherwise it fails to build with W=1. With that added (and
removed in the next fixup patch),

	Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

> 	XE_MTL_IDS(INTEL_VGA_DEVICE, &mtl_desc),
> 	XE_LNL_IDS(INTEL_VGA_DEVICE, &lnl_desc),
> 	{ }
>-- 
>2.43.0
>


More information about the Intel-xe mailing list