[PATCH 2/3] drm/xe/bo: Remove unusued variable

Lucas De Marchi lucas.demarchi at intel.com
Thu Dec 14 21:46:04 UTC 2023


Typo s/unusued/unused/, but I will wait other reviews.

Lucas De Marchi

On Thu, Dec 14, 2023 at 01:39:53PM -0800, Lucas De Marchi wrote:
>bo is not used since all the checks are against tbo. Fix warning:
>
>	../drivers/gpu/drm/xe/xe_bo.c: In function ‘xe_evict_flags’:
>	../drivers/gpu/drm/xe/xe_bo.c:250:23: error: variable ‘bo’ set but not used [-Werror=unused-but-set-variable]
>	  250 |         struct xe_bo *bo;
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>---
> drivers/gpu/drm/xe/xe_bo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
>index 7c0037aecff3..8e4a3b1f6b93 100644
>--- a/drivers/gpu/drm/xe/xe_bo.c
>+++ b/drivers/gpu/drm/xe/xe_bo.c
>@@ -247,8 +247,6 @@ int xe_bo_placement_for_flags(struct xe_device *xe, struct xe_bo *bo,
> static void xe_evict_flags(struct ttm_buffer_object *tbo,
> 			   struct ttm_placement *placement)
> {
>-	struct xe_bo *bo;
>-
> 	if (!xe_bo_is_xe_bo(tbo)) {
> 		/* Don't handle scatter gather BOs */
> 		if (tbo->type == ttm_bo_type_sg) {
>@@ -265,8 +263,6 @@ static void xe_evict_flags(struct ttm_buffer_object *tbo,
> 	 * For xe, sg bos that are evicted to system just triggers a
> 	 * rebind of the sg list upon subsequent validation to XE_PL_TT.
> 	 */
>-
>-	bo = ttm_to_xe_bo(tbo);
> 	switch (tbo->resource->mem_type) {
> 	case XE_PL_VRAM0:
> 	case XE_PL_VRAM1:
>-- 
>2.40.1
>


More information about the Intel-xe mailing list