[PATCH] drm/xe/uapi: Remove reset uevent for now

[Francois Dugast]

+ intel-xe at lists.freedesktop.org

(There was a typo in the original submission to the mailing list)

On Fri, Dec 15, 2023 at 03:37:24PM +0100, Ghimiray, Himal Prasad wrote:
> 
> 
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi at intel.com>
> > Sent: 15 December 2023 06:14
> > To: intel-xe at lists.freedektop.org
> > Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Ghimiray, Himal Prasad
> > <himal.prasad.ghimiray at intel.com>; De Marchi, Lucas
> > <lucas.demarchi at intel.com>; Dugast, Francois <francois.dugast at intel.com>
> > Subject: [PATCH] drm/xe/uapi: Remove reset uevent for now
> > 
> > This kernel uevent is getting removed for now. It will come back later with a
> > better future proof name.
> > 
> > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Cc: Francois Dugast <francois.dugast at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_gt.c | 18 ------------------  include/uapi/drm/xe_drm.h
> > | 10 ----------
> >  2 files changed, 28 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c index
> > dfd9cf01a5d5..9f9527329842 100644
> > --- a/drivers/gpu/drm/xe/xe_gt.c
> > +++ b/drivers/gpu/drm/xe/xe_gt.c
> > @@ -589,20 +589,6 @@ static int do_gt_restart(struct xe_gt *gt)
> >  	return 0;
> >  }
> > 
> > -static void xe_uevent_gt_reset_failure(struct pci_dev *pdev, u8 tile_id, u8
> > gt_id) -{
> > -	char *reset_event[4];
> > -
> > -	reset_event[0] = DRM_XE_RESET_FAILED_UEVENT "=NEEDS_RESET";
> > -	reset_event[1] = kasprintf(GFP_KERNEL, "TILE_ID=%d", tile_id);
> > -	reset_event[2] = kasprintf(GFP_KERNEL, "GT_ID=%d", gt_id);
> > -	reset_event[3] = NULL;
> > -	kobject_uevent_env(&pdev->dev.kobj, KOBJ_CHANGE, reset_event);
> > -
> > -	kfree(reset_event[1]);
> > -	kfree(reset_event[2]);
> > -}
> > -
> >  static int gt_reset(struct xe_gt *gt)
> >  {
> >  	int err;
> > @@ -659,10 +645,6 @@ static int gt_reset(struct xe_gt *gt)
> >  err_fail:
> >  	xe_gt_err(gt, "reset failed (%pe)\n", ERR_PTR(err));
> > 
> > -	/* Notify userspace about gt reset failure */
> > -	xe_uevent_gt_reset_failure(to_pci_dev(gt_to_xe(gt)->drm.dev),
> > -				   gt_to_tile(gt)->id, gt->info.id);
> > -
> >  	gt_to_xe(gt)->needs_flr_on_fini = true;
> > 
> >  	return err;
> > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index
> > 0895e4d2a981..a98cfd3d0496 100644
> > --- a/include/uapi/drm/xe_drm.h
> > +++ b/include/uapi/drm/xe_drm.h
> > @@ -16,16 +16,6 @@ extern "C" {
> >   * subject to backwards-compatibility constraints.
> >   */
> > 
> > -/**
> > - * DOC: uevent generated by xe on it's pci node.
> > - *
> > - * DRM_XE_RESET_FAILED_UEVENT - Event is generated when attempt to
> > reset gt
> > - * fails. The value supplied with the event is always "NEEDS_RESET".
> > - * Additional information supplied is tile id and gt id of the gt unit for
> > - * which reset has failed.
> > - */
> > -#define DRM_XE_RESET_FAILED_UEVENT "DEVICE_STATUS"
> > -
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> >  /**
> >   * struct xe_user_extension - Base class for defining a chain of extensions
> >   *
> > --
> > 2.43.0
>