✓ CI.checkpatch: success for drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Mon Dec 18 18:04:00 UTC 2023
== Series Details ==
Series: drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages (rev4)
URL : https://patchwork.freedesktop.org/series/126495/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 78da78fb026673367c3340c31f582d33af98765e
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date: Wed Dec 6 13:14:41 2023 -0800
drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
We're currently sending non-blocking H2G messages using the EVENT type,
which suppresses all CTB protocol replies from the GuC, including the
failure cases. This might cause errors to slip through and manifest as
unexpected behavior (e.g. a context state might not be what the driver
thinks it is because the state change command was silently rejected by
the GuC). To avoid this kind of problems, we can use the FAST_REQUEST
type instead, which suppresses the reply only on success; this way we
still get the advantage of not having to wait for an ack from the GuC
(i.e. the H2G is still non-blocking) while still detecting errors.
Since we can't escalate to the caller when a non-blocking message
fails, we need to escalate to GT reset instead.
Note that FAST_REQUEST failures are NOT expected and are usually a sign
that the H2G was either malformed or requested an illegal operation.
v2: assign fence values to FAST_REQUEST messages, fix abi doc, use xe_gt
printers (Michal).
v3: fix doc alignment, fix and improve prints (Michal)
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: John Harrison <John.C.Harrison at Intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com> #v2
Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
+ /mt/dim checkpatch 16f9e14e9101e3250294fc3ccb0acb35cd75532d drm-intel
78da78fb0 drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
More information about the Intel-xe
mailing list