[01/17] drm/xe/perf/uapi: "Perf" layer to support multiple perf counter stream types

Guy Zadicario gzadicario at habana.ai
Sun Dec 17 08:45:52 UTC 2023


..

>diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
>index eb03a49c17a13..3539e0781d700 100644
>--- a/include/uapi/drm/xe_drm.h
>+++ b/include/uapi/drm/xe_drm.h

..

>+
>+/**
>+ * enum drm_xe_perf_ioctls - Perf fd ioctl's
>+ */
>+enum drm_xe_perf_ioctls {
>+	/** @DRM_XE_PERF_IOCTL_ENABLE: Enable data capture for a stream */
>+	DRM_XE_PERF_IOCTL_ENABLE = _IO('i', 0x0),
>+
>+	/** @DRM_XE_PERF_IOCTL_DISABLE: Disable data capture for a stream */
>+	DRM_XE_PERF_IOCTL_DISABLE = _IO('i', 0x1),
>+
>+	/** @DRM_XE_PERF_IOCTL_CONFIG: Change stream configuration */
>+	DRM_XE_PERF_IOCTL_CONFIG = _IO('i', 0x2),
>+};
>+

Hi Ashutosh,
It apears that in the hwtrace PERF stream I need to pass some arguments in the ENABLE/DISABLE
ioctls. This is required since firmware will implement the enable/disable functionality.
I would suggest to use different enums for the stream ioctls, you can rename
drm_xe_perf_ioctls to drm_xe_oa_ioctls and I will define drm_xe_hwtrace_ioctls.

I'd also like to add another stream ioctl to retrieve the stream status and avaialable bytes.

Thanks,
Guy.


More information about the Intel-xe mailing list