[PATCH RESEND v5 00/10] Introduce GuC Doorbells Manager

[Thomas Hellström]

On 12/19/23 16:33, Thomas Hellström wrote:
> Hi, Michal,
>
> On 12/18/23 20:06, Michal Wajdeczko wrote:
>> Introduce simple GuC doorbells ID manager that will be used by the
>> PF driver for VFs provisioning and can later be used by submission
>> code once we are ready to switch from H2G based notifications to
>> doorbells mechanism.
>>
>> As preparation steps, improve existing logging and kunit code that
>> is used by the new code.
>>
>> v5: rename drm printfn helpers to follow the header name (Lucas)
>>
>> Michal Wajdeczko (10):
>>    drm/xe: Add GT oriented drm_printers
>>    drm/xe: Report TLB timeout using GT oriented functions
>>    drm/xe: Introduce GuC Doorbells Manager
>>    drm/xe/kunit: Set SR-IOV mode of the fake device
>>    drm/xe/kunit: Define helper functions to allocate fake xe device
>>    drm/xe/kunit: Restore test->priv when done with fake xe device
>>    drm/xe/kunit: Use xe kunit helper in RTP test
>>    drm/xe/kunit: Use xe kunit helper in WA test
>>    drm/xe/kunit: Enable CONFIG_LOCKDEP in tests
>>    drm/xe/kunit: Add GuC Doorbells Manager tests
>
> These kunit changes are neither motivated nor very well described in 
> the cover letter, nor do they align well with the series titles. Those 
> should've been posted as a separate series?
>
> /Thomas
>
After discussing on chat and since the series is already reviewed / acked:

Acked-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>


>> drivers/gpu/drm/xe/.kunitconfig               |   5 +
>>   drivers/gpu/drm/xe/Makefile                   |   4 +
>>   drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c | 201 ++++++++++++++
>>   drivers/gpu/drm/xe/tests/xe_kunit_helpers.c   |  90 ++++++
>>   drivers/gpu/drm/xe/tests/xe_kunit_helpers.h   |  17 ++
>>   drivers/gpu/drm/xe/tests/xe_pci.c             |   3 +
>>   drivers/gpu/drm/xe/tests/xe_pci_test.h        |   2 +
>>   drivers/gpu/drm/xe/tests/xe_rtp_test.c        |   5 +-
>>   drivers/gpu/drm/xe/tests/xe_wa_test.c         |   5 +-
>>   drivers/gpu/drm/xe/xe_gt_printk.h             |  44 +++
>>   drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c   |  13 +-
>>   drivers/gpu/drm/xe/xe_guc_db_mgr.c            | 261 ++++++++++++++++++
>>   drivers/gpu/drm/xe/xe_guc_db_mgr.h            |  22 ++
>>   drivers/gpu/drm/xe/xe_guc_types.h             |  15 +
>>   drivers/gpu/drm/xe/xe_uc.c                    |   5 +
>>   15 files changed, 680 insertions(+), 12 deletions(-)
>>   create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c
>>   create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.c
>>   create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.h
>>   create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.c
>>   create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.h
>>