[PATCH] drm/xe/xelpg: Extend Wa_14019877138 for Graphics 12.7

[Upadhyay, Tejas]

> -----Original Message-----
> From: Roper, Matthew D <matthew.d.roper at intel.com>
> Sent: Tuesday, December 19, 2023 9:56 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> Cc: intel-xe at lists.freedesktop.org
> Subject: Re: [PATCH] drm/xe/xelpg: Extend Wa_14019877138 for Graphics
> 12.7
> 
> On Tue, Dec 19, 2023 at 12:30:18PM +0530, Tejas Upadhyay wrote:
> > Wa_14019877138 is also needed for xe_lpg graphics 12.7
> 
> Driver version numbers aren't decimal numbers, so we shouldn't write "12.7"
> (that would correspond to 12.07, rather than the 12.70/12.71 you intended).
> 
> It doesn't look like this workaround is finalized yet for these IP versions, but
> given that it is already finalized for both newer (Xe2) and older (Xe_HPG)
> versions, it's probably safe to assume this will become official on Xe_LPG as
> well.  You should probably ping the internal workaround records to make sure
> that's moving forward, but in the meantime it's probably fine to go ahead and
> add this.
> 
> Aside from avoiding "12.7" in the commit, message,

Ok, I will take care of this while merging.

> 
>         Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
> 
> Do you have an i915 patch for this?  Since Xe_LPG is used by MTL/ARL,
> i915 is still the official driver where it's important to add this.

Ok, I have not yet checked i915, I will check it and bring this patch there as well if needed.

Tejas
> 
> 
> Matt
> 
> >
> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_wa.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> > index 7d6b86d602c8..3456ca6f7b32 100644
> > --- a/drivers/gpu/drm/xe/xe_wa.c
> > +++ b/drivers/gpu/drm/xe/xe_wa.c
> > @@ -536,6 +536,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
> >  	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1271)),
> >  	  XE_RTP_ACTIONS(SET(CACHE_MODE_1,
> MSAA_OPTIMIZATION_REDUC_DISABLE))
> >  	},
> > +	{ XE_RTP_NAME("14019877138"),
> > +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1271),
> ENGINE_CLASS(RENDER)),
> > +	  XE_RTP_ACTIONS(SET(XEHP_PSS_CHICKEN, FD_END_COLLECT))
> > +	},
> >
> >  	/* Xe2_LPG */
> >
> > --
> > 2.25.1
> >
> 
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation