[PATCH] drm/xe: Remove uninitialized variable from warning
Michał Winiarski
michal.winiarski at intel.com
Wed Dec 20 16:39:27 UTC 2023
On Wed, Dec 20, 2023 at 08:19:23AM -0800, Lucas De Marchi wrote:
> "err" is not initialized when failing to create and add the freq0 sysfs
> file. Remove it from the message. This fixes the following warning with
> clang:
>
> ../drivers/gpu/drm/xe/xe_gt_freq.c:202:30: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
> kobject_name(gt->sysfs), err);
> ^~~
>
> Fixes: fc5b7e3efff3 ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>
-Michał
> ---
> drivers/gpu/drm/xe/xe_gt_freq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c
> index 08eabcafe7bc..3adfa6686e7c 100644
> --- a/drivers/gpu/drm/xe/xe_gt_freq.c
> +++ b/drivers/gpu/drm/xe/xe_gt_freq.c
> @@ -198,8 +198,8 @@ void xe_gt_freq_init(struct xe_gt *gt)
>
> gt->freq = kobject_create_and_add("freq0", gt->sysfs);
> if (!gt->freq) {
> - drm_warn(&xe->drm, "failed to add freq0 directory to %s, err: %d\n",
> - kobject_name(gt->sysfs), err);
> + drm_warn(&xe->drm, "failed to add freq0 directory to %s\n",
> + kobject_name(gt->sysfs));
> return;
> }
>
> --
> 2.40.1
>
More information about the Intel-xe
mailing list