[PATCH] drm/xe: Check skip_guc_pc before setting SLPC flag

[Lucas De Marchi]

On Fri, Dec 22, 2023 at 01:01:09PM -0800, Vinay Belgaumkar wrote:
>Don't set SLPC GuC feature ctl flag if skip_guc_pc is true.
>
>Fixes: 975e4a3795d4 ("drm/xe: Manually setup C6 when skip_guc_pc is set")
>Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_guc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
>index 811e8b201270..0e112b144ec8 100644
>--- a/drivers/gpu/drm/xe/xe_guc.c
>+++ b/drivers/gpu/drm/xe/xe_guc.c
>@@ -62,7 +62,12 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
>
> static u32 guc_ctl_feature_flags(struct xe_guc *guc)
> {
>-	return GUC_CTL_ENABLE_SLPC;
>+	u32 flags = 0;
>+
>+	if (!(guc_to_xe(guc))->info.skip_guc_pc)
>+		flags |= GUC_CTL_ENABLE_SLPC;
>+
>+	return flags;
> }
>
> static u32 guc_ctl_log_params_flags(struct xe_guc *guc)
>-- 
>2.38.1
>