[Intel-xe] [PATCH 37/37] drm/xe: enforce GSMBASE for DG1 instead of BAR2

[Matthew Auld]

On 01/02/2023 09:12, Matthew Auld wrote:
> On 31/01/2023 19:13, Rodrigo Vivi wrote:
>> On Tue, Jan 24, 2023 at 04:25:16PM +0000, Lecluse, Philippe wrote:
>>> On DG1, BAR2 is not reliable for reporting Vram size, need to use 
>>> GSMBASE.
>>> Simplify xe_mmio_total_vram_size to report vram size and usable size.
> 
> s/reliable/valid/
> s/Vram size/usable VRAM size/
> 
>>
>> Matt, with this as commit msg of this patch, can I convert your gitlab 
>> approval in rv-b?
> 
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
> 
>>
>> What about other gitlab approvals? can I convert them to rv-b or
>> do you intend to go patch by patch here in the ml?
> 
> Sure.

I mean sure, feel free to convert to r-b.

> 
>>
>> Thanks,
>> Rodrigo.
>>
>>>
>>> -----Original Message-----
>>> From: Vivi, Rodrigo <rodrigo.vivi at intel.com>
>>> Sent: Tuesday, January 24, 2023 4:46 PM
>>> To: intel-xe at lists.freedesktop.org; Brost, Matthew 
>>> <matthew.brost at intel.com>; maarten.lankhorst at linux.intel.com; 
>>> Lecluse, Philippe <philippe.lecluse at intel.com>; mchehab at kernel.org
>>> Cc: Auld, Matthew <matthew.auld at intel.com>
>>> Subject: Re: [Intel-xe] [PATCH 37/37] drm/xe: enforce GSMBASE for DG1 
>>> instead of BAR2
>>>
>>> On Thu, Jan 12, 2023 at 05:25:38PM -0500, Rodrigo Vivi wrote:
>>>> From: Philippe Lecluse <philippe.lecluse at intel.com>
>>>
>>> Hi Phil, could you please reply with a commit message to this patch?
>>> I will add on the next interaction or while merging it.
>>>
>>> Thanks,
>>> Rodrigo.
>>> ---------------------------------------------------------------------
>>> Intel Benelux B.V.
>>> Registered in The Netherlands under number 24134020
>>> Statutory seat: Rotterdam
>>> Registered address: Capronilaan 37, 1119NG Schiphol-Rijk
>>>
>>> This e-mail and any attachments may contain confidential material for
>>> the sole use of the intended recipient(s). Any review or distribution
>>> by others is strictly prohibited. If you are not the intended
>>> recipient, please contact the sender and delete all copies.
>>>