[Intel-xe] [PATCH 1/4] drm/xe/fbc: set compressed_fb to NULL on error

[Lucas De Marchi]

On Fri, Feb 03, 2023 at 03:17:55PM -0500, Rodrigo Vivi wrote:
>From: Matthew Auld <matthew.auld at intel.com>
>
>On DG2 we get a massive flood of the following:
>
>[ 1068.790446] xe 0000:03:00.0: drm_WARN_ON((!!(fbc->compressed_fb)))
>[ 1068.790465] WARNING: CPU: 9 PID: 637 at drivers/gpu/drm/xe/display/intel_fbc.c:843 intel_fbc_update+0x605/0x670 [xe]
>
>Signed-off-by: Matthew Auld <matthew.auld at intel.com>
>Cc: Maarten Lankhort <maarten.lankhorst at linux.intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

alghough this display integration with ifdef copying i915_gem_stolen_insert_node_in_range()
looks ugly

Lucas De Marchi

>---
> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
>index 82bc21b09332..13f03c6ea818 100644
>--- a/drivers/gpu/drm/i915/display/intel_fbc.c
>+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>@@ -75,7 +75,7 @@ static int i915_gem_stolen_insert_node_in_range(struct xe_device *xe, struct xe_
> 					ttm_bo_type_kernel, flags);
> 	if (IS_ERR(*bo)) {
> 		err = PTR_ERR(*bo);
>-		bo = NULL;
>+		*bo = NULL;
> 		return err;
> 	}
> 	err = xe_bo_pin(*bo);
>-- 
>2.39.1
>