[Intel-xe] [PATCH 05/15] drm/xe/bo: explicitly reject zero sized BO
Matthew Auld
matthew.auld at intel.com
Tue Feb 14 11:21:26 UTC 2023
In the depths of ttm, when allocating the vma node this should result in
-ENOSPC it seems. However we should probably rather reject as part of
our own ioctl sanity checking, and then treat as programmer error in the
lower levels.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 9b7b9c8f84be..98716b56498f 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -962,6 +962,9 @@ struct xe_bo *__xe_bo_create_locked(struct xe_device *xe, struct xe_bo *bo,
/* Only kernel objects should set GT */
XE_BUG_ON(gt && type != ttm_bo_type_kernel);
+ if (XE_WARN_ON(!size))
+ return ERR_PTR(-EINVAL);
+
if (!bo) {
bo = xe_bo_alloc();
if (IS_ERR(bo))
@@ -1516,6 +1519,9 @@ int xe_gem_create_ioctl(struct drm_device *dev, void *data,
if (XE_IOCTL_ERR(xe, args->handle))
return -EINVAL;
+ if (XE_IOCTL_ERR(xe, !args->size))
+ return -EINVAL;
+
if (XE_IOCTL_ERR(xe, args->size > SIZE_MAX))
return -EINVAL;
--
2.39.1
More information about the Intel-xe
mailing list