[Intel-xe] [PATCH 1/6] drm/xe: Make local functions static

Matthew Auld matthew.william.auld at gmail.com
Wed Feb 22 09:48:27 UTC 2023


On Tue, 21 Feb 2023 at 23:34, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>
> A few static functions not being declared like that break the build with
> W=1, like e.g.
>
>         cc1: all warnings being treated as errors
>         make[2]: *** [../scripts/Makefile.build:250: drivers/gpu/drm/xe/xe_gt.o] Error 1
>         ../drivers/gpu/drm/xe/xe_guc.c:240:6: error: no previous prototype for ‘guc_write_params’ [-Werror=missing-prototypes]
>           240 | void guc_write_params(struct xe_guc *guc)
>               |      ^~~~~~~~~~~~~~~~
>
> Make them static.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-xe mailing list