[Intel-xe] [PATCH v4 09/12] drm/xe: Remove dependency on intel_mchbar_regs.h
Lucas De Marchi
lucas.demarchi at intel.com
Sat Feb 25 00:15:45 UTC 2023
The only thing really needed is the base offset, MCHBAR_MIRROR_BASE_SNB.
Remove the include and just define it inplace.
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/display/ext/intel_device_info.h | 2 ++
drivers/gpu/drm/xe/xe_display.h | 5 ++---
drivers/gpu/drm/xe/xe_guc_pc.c | 10 +++++-----
3 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/ext/intel_device_info.h b/drivers/gpu/drm/xe/display/ext/intel_device_info.h
index dd05f298019e..959acb261007 100644
--- a/drivers/gpu/drm/xe/display/ext/intel_device_info.h
+++ b/drivers/gpu/drm/xe/display/ext/intel_device_info.h
@@ -28,6 +28,8 @@
#include <linux/types.h>
#include "xe_device_types.h"
+struct drm_i915_private;
+
/* Minimal parts used by xe */
#define intel_runtime_info xe_device_display_info
diff --git a/drivers/gpu/drm/xe/xe_display.h b/drivers/gpu/drm/xe/xe_display.h
index 262cd5442489..5c09962f4906 100644
--- a/drivers/gpu/drm/xe/xe_display.h
+++ b/drivers/gpu/drm/xe/xe_display.h
@@ -6,13 +6,11 @@
#ifndef _XE_DISPLAY_H_
#define _XE_DISPLAY_H_
-#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
#include <drm/drm_drv.h>
#include "xe_device.h"
-#include "display/ext/i915_irq.h"
-#include "display/intel_opregion.h"
+#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
int xe_display_enable(struct pci_dev *pdev, struct drm_driver *driver);
@@ -44,6 +42,7 @@ void xe_display_pm_resume_early(struct xe_device *xe);
void xe_display_pm_resume(struct xe_device *xe);
#else
+
static inline int
xe_display_enable(struct pci_dev *pdev, struct drm_driver *driver) { return 0; };
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index d91dad8638ef..5a8d827ba770 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -21,12 +21,12 @@
#include "xe_mmio.h"
#include "xe_pcode.h"
-#include "intel_mchbar_regs.h"
+#define MCHBAR_MIRROR_BASE_SNB 0x140000
-/* For GEN6_RP_STATE_CAP.reg to be merged when the definition moves to Xe */
-#define RP0_MASK REG_GENMASK(7, 0)
-#define RP1_MASK REG_GENMASK(15, 8)
-#define RPN_MASK REG_GENMASK(23, 16)
+#define GEN6_RP_STATE_CAP _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5998)
+#define RP0_MASK REG_GENMASK(7, 0)
+#define RP1_MASK REG_GENMASK(15, 8)
+#define RPN_MASK REG_GENMASK(23, 16)
#define GEN10_FREQ_INFO_REC _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5ef0)
#define RPE_MASK REG_GENMASK(15, 8)
--
2.39.0
More information about the Intel-xe
mailing list