[Intel-xe] [PATCH v2 01/14] drm/xe/display: fix IS_ALDERLAKE_P()

Lucas De Marchi lucas.demarchi at intel.com
Tue Feb 28 18:54:43 UTC 2023


On Tue, Feb 28, 2023 at 10:41:24AM +0000, Matthew Auld wrote:
>On ADL-P we currently trigger:
>
>xe 0000:00:02.0: drm_WARN_ON(!((dev_priv)->info.platform == XE_ALDERLAKE_S) && !(dev_priv && 0))
>WARNING: CPU: 3 PID: 338 at drivers/gpu/drm/xe/display/ext/intel_pch.c:32 intel_pch_type+0xce/0x2f0 [xe]
>

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/231

or maybe just "References" ?


>Signed-off-by: Matthew Auld <matthew.auld at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>


Lucas De Marchi

>---
> drivers/gpu/drm/xe/display/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/display/i915_drv.h b/drivers/gpu/drm/xe/display/i915_drv.h
>index da83a957dd86..06348cb03f44 100644
>--- a/drivers/gpu/drm/xe/display/i915_drv.h
>+++ b/drivers/gpu/drm/xe/display/i915_drv.h
>@@ -73,7 +73,7 @@ static inline struct drm_i915_private *kdev_to_i915(struct device *kdev)
> #define IS_ROCKETLAKE(dev_priv)	(dev_priv && 0)
> #define IS_DG1(dev_priv)        IS_PLATFORM(dev_priv, XE_DG1)
> #define IS_ALDERLAKE_S(dev_priv) IS_PLATFORM(dev_priv, XE_ALDERLAKE_S)
>-#define IS_ALDERLAKE_P(dev_priv) (dev_priv && 0)
>+#define IS_ALDERLAKE_P(dev_priv) IS_PLATFORM(dev_priv, XE_ALDERLAKE_P)
> #define IS_XEHPSDV(dev_priv) (dev_priv && 0)
> #define IS_DG2(dev_priv)	IS_PLATFORM(dev_priv, XE_DG2)
> #define IS_PONTEVECCHIO(dev_priv) IS_PLATFORM(dev_priv, XE_PVC)
>-- 
>2.39.2
>


More information about the Intel-xe mailing list