[Intel-xe] [PATCH 01/23] Revert "HAX sound: Disable probing snd_hda with DG1"
Rodrigo Vivi
rodrigo.vivi at intel.com
Tue Jan 10 22:05:48 UTC 2023
From: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
This reverts commit 169d52c98bdc6e6c8b343b0accd92351a5a65f17.
No longer required since "ALSA: hda/i915 - skip acomp init if no matching display".
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
sound/hda/hdac_i915.c | 23 -----------------------
sound/pci/hda/hda_intel.c | 2 ++
2 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index 2b13c49a1061..161a9711cd63 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -133,26 +133,6 @@ static int i915_gfx_present(struct pci_dev *hdac_pci)
return false;
}
-static bool dg1_gfx_present(void)
-{
- static const struct pci_device_id ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x4905),
- .class = PCI_BASE_CLASS_DISPLAY << 16,
- .class_mask = 0xff << 16 },
- { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x4906),
- .class = PCI_BASE_CLASS_DISPLAY << 16,
- .class_mask = 0xff << 16 },
- { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x4907),
- .class = PCI_BASE_CLASS_DISPLAY << 16,
- .class_mask = 0xff << 16 },
- { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x4908),
- .class = PCI_BASE_CLASS_DISPLAY << 16,
- .class_mask = 0xff << 16 },
- {}
- };
- return pci_dev_present(ids);
-}
-
/**
* snd_hdac_i915_init - Initialize i915 audio component
* @bus: HDA core bus
@@ -173,9 +153,6 @@ int snd_hdac_i915_init(struct hdac_bus *bus)
if (!i915_gfx_present(to_pci_dev(bus->dev)))
return -ENODEV;
- if (dg1_gfx_present())
- return -ENODEV;
-
err = snd_hdac_acomp_init(bus, NULL,
i915_component_master_match,
sizeof(struct i915_audio_component) - sizeof(*acomp));
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index e68fbda11809..87002670c0c9 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2249,6 +2249,8 @@ static int azx_probe_continue(struct azx *chip)
* codecs can be on the same link.
*/
if (CONTROLLER_IN_GPU(pci)) {
+ dev_err(chip->card->dev,
+ "HSW/BDW HD-audio HDMI/DP requires binding with gfx driver\n");
goto out_free;
} else {
/* don't bother any longer */
--
2.38.1
More information about the Intel-xe
mailing list