[Intel-xe] [PATCH 22/37] drm/xe: Fix compilation when Xe driver is builtin

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Jan 12 22:25:23 UTC 2023


From: Mauro Carvalho Chehab <mchehab at kernel.org>

Trying to build the driver as builtin with ACPI_WMI=m causes
a Kconfig error:

	WARNING: unmet direct dependencies detected for ACPI_VIDEO
	  Depends on [m]: ACPI [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] && (ACPI_WMI [=m] || !X86 [=y])
	  Selected by [y]:
	  - DRM_XE [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && MMU [=y] && X86 [=y] && ACPI [=y]

As a workaround, let's also select ACPI_WMI. It should be noticed
that the real solution would be to avoid doing so many selects, using
a depends on instead, but that would require a major rework on Xe
(and probably i915) Kconfig files.

Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index f7780c120731..3815e25d0eec 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -24,6 +24,7 @@ config DRM_XE
 	select INPUT if ACPI
 	select ACPI_VIDEO if X86 && ACPI
 	select ACPI_BUTTON if ACPI
+	select ACPI_WMI if ACPI
 	select SYNC_FILE
 	select IOSF_MBI
 	select CRC32
-- 
2.38.1



More information about the Intel-xe mailing list