[Intel-xe] [PATCH 03/20] drm/xe/pcode: fix pcode error check
Rodrigo Vivi
rodrigo.vivi at intel.com
Fri Jan 20 20:44:09 UTC 2023
From: Matthew Auld <matthew.auld at intel.com>
On DG2 we are now getting:
[ 104.456607] xe 0000:03:00.0: [drm] *ERROR* PCODE timeout, retrying with preemption disabled
Looks like we just need to invert the error check for
xe_pcode_try_request(), which returns zero on success.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/xe_pcode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
index 39712e843728..1a76fe478853 100644
--- a/drivers/gpu/drm/xe/xe_pcode.c
+++ b/drivers/gpu/drm/xe/xe_pcode.c
@@ -155,7 +155,7 @@ int xe_pcode_request(struct xe_gt *gt, u32 mbox, u32 request,
ret = xe_pcode_try_request(gt, mbox, request, reply_mask, reply, &status,
false, timeout_base_ms * 1000);
- if (ret)
+ if (!ret)
goto out;
/*
--
2.39.0
More information about the Intel-xe
mailing list