[Intel-xe] [PATCH v2 0/6] Add HWMON support for DGFX

Dixit, Ashutosh ashutosh.dixit at intel.com
Mon Jul 3 01:48:20 UTC 2023


On Sun, 02 Jul 2023 13:51:40 -0700, Guenter Roeck wrote:
>
> On 7/2/23 13:29, Dixit, Ashutosh wrote:
>
> > Of course people might have been abusing the deprecated API's (or NULL chip
> > parameter) but to me it seems there is also some legitimate use for them.
> >
>
> You still neglect to explain what you think that legitimate use would be.

To me "drivers/gpu/drm/amd/pm/amdgpu_pm.c" is a legitimate use case which
doesn't use chip_info (both standard and custom hwmon attributes are
defined without using chip_info). "drivers/gpu/drm/i915/i915_hwmon.c" has
all this extra code related to chip_info/channel_info which is not
needed. i915 could well move to the amdgpu model and that would reduce i915
code. That is what I was originally proposing for this new patch series.

Ashutosh


More information about the Intel-xe mailing list