[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Make explicit that exec uAPI expects canonical addresses

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 3 19:45:29 UTC 2023


== Series Details ==

Series: drm/xe: Make explicit that exec uAPI expects canonical addresses
URL   : https://patchwork.freedesktop.org/series/120143/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5df023e64913f7f7e0bb2ab28b66087231613fcc
Author: José Roberto de Souza <jose.souza at intel.com>
Date:   Mon Jul 3 12:01:05 2023 -0700

    drm/xe: Make explicit that exec uAPI expects canonical addresses
    
    The batch buffer address in exec uAPI is used when emitting
    MI_BATCH_BUFFER_START that expect canonical addresses in future
    platforms, for current ones the bits above 57 for PVC and 47 for
    other platforms are ignored.
    
    So the safest approach is to require canonical address for all
    platforms supported by Xe to avoid uAPI breaks.
    
    BSpec: 60223 59475 45718
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch 103e5d7aa1ba8469687574c926f40c630252ede4 drm-intel
5df023e64 drm/xe: Make explicit that exec uAPI expects canonical addresses
-:35: WARNING:LINE_SPACING: Missing a blank line after declarations
#35: FILE: drivers/gpu/drm/xe/xe_device.c:444:
+	const int high_address_bit = xe->info.dma_mask_size > 47 ? 57 : 47;
+	return sign_extend64(address, high_address_bit);

-:60: WARNING:LINE_SPACING: Missing a blank line after declarations
#60: FILE: drivers/gpu/drm/xe/xe_exec.c:236:
+		const u64 canonical_addr = xe_device_canonical_addr(xe, addresses[i]);
+		if (XE_IOCTL_ERR(xe, addresses[i] != canonical_addr)) {

total: 0 errors, 2 warnings, 0 checks, 41 lines checked




More information about the Intel-xe mailing list