[Intel-xe] ✗ CI.checkpatch: warning for Try to handle TLB invalidations from CT fast-path
Patchwork
patchwork at emeril.freedesktop.org
Tue Jul 4 13:49:01 UTC 2023
== Series Details ==
Series: Try to handle TLB invalidations from CT fast-path
URL : https://patchwork.freedesktop.org/series/120174/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 73a9cb7badb7e074d3379ef110f2c597683d5f38
Author: Matthew Auld <matthew.auld at intel.com>
Date: Tue Jul 4 14:45:30 2023 +0100
drm/xe: handle TLB invalidations from CT fast-path
In various test cases that put the system under a heavy load, we can
sometimes see errors with missed TLB invalidations. In such cases we see
the interrupt arrive for the invalidation from the GuC, however the
actual processing of the completion is pushed onto a workqueue and
handled with all the other CT stuff, which might take longer than
expected. Since we expect TLB invalidations to complete within a
reasonable amount of time (at most ~250ms), and they do seem pretty
critical, allow handling directly from the CT fast-path.
v2 (José):
- Actually use the correct spinlock/unlock_irq, since pending_lock is
grabbed from IRQ.
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch cd26cb9c94f4f04586f04fca4e94181c53854c46 drm-intel
44faaa962 drm/xe: hold mem_access.ref for CT fast-path
a462e5f93 drm/xe/ct: serialise fast_lock during CT disable
19443436d drm/xe/gt: tweak placement for signalling TLB fences after GT reset
340b7185b drm/xe/tlb: also update seqno_recv during reset
-:45: WARNING:MEMORY_BARRIER: memory barrier without comment
#45: FILE: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c:109:
+ smp_wmb();
total: 0 errors, 1 warnings, 0 checks, 27 lines checked
73a9cb7ba drm/xe: handle TLB invalidations from CT fast-path
-:22: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#22:
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297
-:23: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#23:
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320
-:24: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#24:
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449
total: 0 errors, 3 warnings, 0 checks, 174 lines checked
More information about the Intel-xe
mailing list