[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Make explicit that exec uAPI expects canonical addresses (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 4 14:44:13 UTC 2023


== Series Details ==

Series: drm/xe: Make explicit that exec uAPI expects canonical addresses (rev2)
URL   : https://patchwork.freedesktop.org/series/120143/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 78fd216d109d74e8e549b709ff04d4cae1074819
Author: José Roberto de Souza <jose.souza at intel.com>
Date:   Tue Jul 4 07:24:40 2023 -0700

    drm/xe: Make explicit that exec uAPI expects canonical addresses
    
    The batch buffer address in exec uAPI is used when emitting
    MI_BATCH_BUFFER_START that expect canonical addresses in future
    platforms, for current ones the bits above 57 for PVC and 47 for
    other platforms are ignored.
    
    So the safest approach is to require canonical address for all
    platforms supported by Xe to avoid uAPI breaks.
    
    v2:
    - fix check for non parallel engines
    
    BSpec: 60223 59475 45718
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch cd26cb9c94f4f04586f04fca4e94181c53854c46 drm-intel
78fd216d1 drm/xe: Make explicit that exec uAPI expects canonical addresses
-:38: WARNING:LINE_SPACING: Missing a blank line after declarations
#38: FILE: drivers/gpu/drm/xe/xe_device.c:444:
+	const int high_address_bit = xe->info.dma_mask_size > 47 ? 57 : 47;
+	return sign_extend64(address, high_address_bit);

-:64: WARNING:LINE_SPACING: Missing a blank line after declarations
#64: FILE: drivers/gpu/drm/xe/xe_exec.c:235:
+			const u64 canonical_addr = xe_device_canonical_addr(xe, addresses[i]);
+			if (XE_IOCTL_ERR(xe, addresses[i] != canonical_addr)) {

-:71: WARNING:LINE_SPACING: Missing a blank line after declarations
#71: FILE: drivers/gpu/drm/xe/xe_exec.c:242:
+		const u64 canonical_addr = xe_device_canonical_addr(xe, args->address);
+		if (XE_IOCTL_ERR(xe, args->address != canonical_addr)) {

total: 0 errors, 3 warnings, 0 checks, 47 lines checked




More information about the Intel-xe mailing list