[Intel-xe] [PATCH V2] drm/xe: make GT sysfs init return void

[Upadhyay, Tejas]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Wednesday, July 5, 2023 7:36 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> Cc: intel-xe at lists.freedesktop.org; Das, Nirmoy <nirmoy.das at intel.com>;
> Shyti, Andi <andi.shyti at intel.com>
> Subject: Re: [Intel-xe] [PATCH V2] drm/xe: make GT sysfs init return void
> 
> On Wed, 05 Jul 2023 01:44:03 -0700, Tejas Upadhyay wrote:
> >
> > Currently return from xe_gt_sysfs_init() is ignored and also a failure
> > in xe_gt_sysfs_init() isn't fatal so make it return void.
> 
> But why is the failure not fatal? I really don't understand the concept of these
> non-fatal failures. Do we really want to say the device is up if sysfs
> initialization has failed for some reason and people are unable to see card
> freq's e.g.? This was done in i915 but do we really want to repeat this for xe?
> IMO the simplest thing to do would be to fail the probe unless ALL
> required/intended functionality is clearly up.
> 
> Instead of ignoring the return, fail the probe?

In my opinion, not creating sysfs cant be driver probe failure. Driver still can work with its core functionality when one sysfs entry creation fails for some reason (example, sysfs dir already present or memory exhausted at the very moment etc.). Still other can comment.

Thanks,
Tejas

> 
> Thanks.
> --
> Ashutosh