[Intel-xe] ✓ CI.checkpatch: success for drm/xe: Fix bo refcounting in intel_framebuffer

Patchwork patchwork at emeril.freedesktop.org
Thu Jul 6 16:23:12 UTC 2023


== Series Details ==

Series: drm/xe: Fix bo refcounting in intel_framebuffer
URL   : https://patchwork.freedesktop.org/series/120310/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit bdf42292b4d057e342165a47d14bc023c4fc0592
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Thu Jul 6 18:11:30 2023 +0200

    drm/xe: Fix bo refcounting in intel_framebuffer
    
    Seems we have various confused refcounting mechanisms.
    intel_frontbuffer.c was holding a reference on the bo, but it should be
    handled in the framebuffer.
    
    A few rebases before, there was code that explicitly adds a refcount in
    intel_fb_init, but chunks of that have disappeared. The changes in
    xe_plane_initial are reminders of it.
    
    By adding a refcount, we match how drm_gem_framebuffer_helper handles
    things. In i915, this is opaquely (and accidentally?) handled through
    intel_frontbuffer_get(), not going to duplicate that mistake in xe.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch abcb88850f885254cf7477e1f7a5956136fb547c drm-intel
bdf42292b drm/xe: Fix bo refcounting in intel_framebuffer




More information about the Intel-xe mailing list