[Intel-xe] [PATCH 2/2] fixup! drm/xe/display: Implement display support

Lucas De Marchi lucas.demarchi at intel.com
Fri Jul 7 20:48:58 UTC 2023


On Thu, Jul 06, 2023 at 05:46:30PM +0300, Jani Nikula wrote:
>On Thu, 06 Jul 2023, Francois Dugast <francois.dugast at intel.com> wrote:
>> Fix some SPDX license identifier warnings reported by checkpatch
>> in the display code.
>>
>> Signed-off-by: Francois Dugast <francois.dugast at intel.com>
>> ---
>>  .../xe/compat-i915-headers/soc/intel_dram.h   |  5 +++++
>>  .../xe/compat-i915-headers/soc/intel_pch.h    |  5 +++++
>>  .../drm/xe/display/ext/intel_clock_gating.c   | 20 +-----------------
>>  .../drm/xe/display/ext/intel_device_info.c    | 21 +------------------
>>  .../drm/xe/display/ext/intel_device_info.h    | 21 +------------------
>>  5 files changed, 13 insertions(+), 59 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_dram.h b/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_dram.h
>> index 1532ca7e0af6..65707e20c557 100644
>> --- a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_dram.h
>> +++ b/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_dram.h
>> @@ -1 +1,6 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2023 Intel Corporation
>> + */
>> +
>
>The entire file is just a single line include, and it's going to stay
>that way. I really did not see much point in adding license or copyright
>boilerplate.
>
>>  #include "../../../i915/soc/intel_dram.h"
>> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_pch.h b/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_pch.h
>> index 823803f7e853..9c46556d33a4 100644
>> --- a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_pch.h
>> +++ b/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_pch.h
>> @@ -1 +1,6 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2023 Intel Corporation
>> + */
>> +
>
>Ditto.
>
>>  #include "../../../i915/soc/intel_pch.h"
>> diff --git a/drivers/gpu/drm/xe/display/ext/intel_clock_gating.c b/drivers/gpu/drm/xe/display/ext/intel_clock_gating.c
>> index 0d67b0961d74..766c21a19181 100644
>> --- a/drivers/gpu/drm/xe/display/ext/intel_clock_gating.c
>> +++ b/drivers/gpu/drm/xe/display/ext/intel_clock_gating.c
>> @@ -1,25 +1,7 @@
>> +// SPDX-License-Identifier: MIT
>>  /*
>>   * Copyright © 2012 Intel Corporation
>>   *
>> - * Permission is hereby granted, free of charge, to any person obtaining a
>> - * copy of this software and associated documentation files (the "Software"),
>> - * to deal in the Software without restriction, including without limitation
>> - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> - * and/or sell copies of the Software, and to permit persons to whom the
>> - * Software is furnished to do so, subject to the following conditions:
>> - *
>> - * The above copyright notice and this permission notice (including the next
>> - * paragraph) shall be included in all copies or substantial portions of the
>> - * Software.
>> - *
>> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>> - * IN THE SOFTWARE.
>> - *
>
>The file is copy-paste from i915 for the time being. Please let's not
>deviate from the original for no real benefit. It'll be easier to
>deduplicate later.

i.e. it should be fine to change it in the original file. Or... these
files here in ext/ are supposedly to go away soon (?), so there's not
much point touching them.

Lucas De Marchi


More information about the Intel-xe mailing list