[Intel-xe] [PATCH v2 2/2] drm/xe/pmu: Enable PMU interface

[Dixit, Ashutosh]

On Sun, 09 Jul 2023 21:13:59 -0700, Iddamsetty, Aravind wrote:
>
> On 09-07-2023 06:02, Dixit, Ashutosh wrote:
> > On Thu, 06 Jul 2023 20:53:47 -0700, Iddamsetty, Aravind wrote:
> >> On 07-07-2023 07:48, Dixit, Ashutosh wrote:
> >>> On Thu, 06 Jul 2023 06:42:29 -0700, Iddamsetty, Aravind wrote:
> >>> Also, could you please explain where the requirement to expose these OAG
> >>> group busy/free registers via the PMU is coming from? Since these are OA
> >>> registers presumably they can be collected using the OA subsystem.
> >>
> >> L0 sysman needs this
> >> https://spec.oneapi.io/level-zero/latest/sysman/api.html#zes-engine-properties-t
> >> and xpumanager uses this
> >> https://github.com/intel/xpumanager/blob/master/core/src/device/gpu/gpu_device.cpp
> >
> > Also there is the above mentioned open regarding this: "Since these are OA
> > registers presumably they can be collected using the OA subsystem". L0 now
> > seems to be supporting OA and we are going to provide an OA subsystem for
> > xe. This probably also needs arch input.
>
> While I try to check on this, by any chance do you know why we have to
> go with custom OA subsystem implementation and cannot use PMU for
> reporting OA.

Because we already had a big OA subsystem in i915 (i915_perf.c) which we
are bringing over to xe. And OA has many more metrics than just the few we
are exposing (or had exposed via the PMU). You can see these metrics in
build/lib directory of the IGT build (after you compile IGT). Grep for
busyness. Some of metrics which come from GuC will not be available from OA
(since OA data is HW generated) so we will have to expose these separately.

Separately, I think it would be good to understand how other drm drivers
expose such performance data (such as what we were doing in i915 with OA
and PMU) for userland to digest.

Let's see. I am not against PMU per se, just asking questions so we can get
some opinion about these things before we commit to supporting the PMU
interface.

Thanks.
--
Ashutosh