[Intel-xe] ✗ CI.checkpatch: warning for Try to handle TLB invalidations from CT fast-path (rev4)

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 10 10:13:57 UTC 2023


== Series Details ==

Series: Try to handle TLB invalidations from CT fast-path (rev4)
URL   : https://patchwork.freedesktop.org/series/120174/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d77c82ed5cae10ca54e82530253d754dd1146714
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Jul 10 10:40:49 2023 +0100

    drm/xe: handle TLB invalidations from CT fast-path
    
    In various test cases that put the system under a heavy load, we can
    sometimes see errors with missed TLB invalidations. In such cases we see
    the interrupt arrive for the invalidation from the GuC, however the
    actual processing of the completion is pushed onto a workqueue and
    handled with all the other CT stuff, which might take longer than
    expected. Since we expect TLB invalidations to complete within a
    reasonable amount of time (at most ~250ms), and they do seem pretty
    critical, allow handling directly from the CT fast-path.
    
    v2 (José):
      - Actually use the correct spinlock/unlock_irq, since pending_lock is
        grabbed from IRQ.
    v3:
      - Don't publish the TLB fence on the list until after we fully
        initialize it and successfully do the CT send. The list is now only
        protected by the spin_lock pending_lock and we can't hold that
        across the entire TLB send operation.
    v4 (Matt Brost):
      - Be careful with racing against fast CT path writing the seqno,
        before we have actually published the fence.
    
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: José Roberto de Souza <jose.souza at intel.com>
    Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch bcc6a60a1130ef5b99f6347dcc553ab04cbf3365 drm-intel
f3bcd2526 drm/xe/tlb: drop unnecessary smp_wmb()
1f73f5d20 drm/xe/tlb: ensure we access seqno_recv once
2fc287e85 drm/xe: hold mem_access.ref for CT fast-path
00683543d drm/xe/ct: hold fast_lock when reserving space for g2h
fc99e9be1 drm/xe/tlb: increment next seqno after successful CT send
f6824b5e1 drm/xe/ct: serialise fast_lock during CT disable
6cf11f309 drm/xe/gt: tweak placement for signalling TLB fences after GT reset
71749d02e drm/xe/tlb: also update seqno_recv during reset
b3ee973f7 drm/xe/tlb: print seqno_recv on fence TLB timeout
c5c5223ed drm/xe/ct: update g2h outstanding for CTB capture
d77c82ed5 drm/xe: handle TLB invalidations from CT fast-path
-:30: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#30: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297

-:31: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#31: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320

-:32: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#32: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449

total: 0 errors, 3 warnings, 0 checks, 265 lines checked




More information about the Intel-xe mailing list