[Intel-xe] ✗ CI.checkpatch: warning for Prevent flooding the kernel log with XE_IOCTL_ERR (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 11 10:35:24 UTC 2023


== Series Details ==

Series: Prevent flooding the kernel log with XE_IOCTL_ERR (rev2)
URL   : https://patchwork.freedesktop.org/series/120535/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d2814e1755ce350e92cbf1825869a5718c22efdd
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Tue Jul 11 10:16:33 2023 +0000

    drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR
    
    Lower log level of XE_IOCTL_ERR macro to debug in order to prevent
    flooding kernel log. Rely on drm_dbg macro output which includes
    function name, so removing file and name macros.
    
    v2: Rename XE_IOCTL_ERR to XE_IOCTL_DBG (Rodrigo Vivi)
    v3: Rebase
    
    Reported-by: Oded Gabbay <ogabbay at kernel.org>
    Link: https://lists.freedesktop.org/archives/intel-xe/2023-May/004704.html
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch d39e49e2ad386bf59f585a05ab659563e0472314 drm-intel
d2814e175 drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: Oded Gabbay <ogabbay at kernel.org>
Link: https://lists.freedesktop.org/archives/intel-xe/2023-May/004704.html

-:337: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#337: FILE: drivers/gpu/drm/xe/xe_engine.c:542:
+	if (XE_IOCTL_DBG(xe, eci[0].gt_id >= xe->info.tile_count))
 	       return -EINVAL;

-:908: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#908: FILE: drivers/gpu/drm/xe/xe_vm.c:2172:
+		if (XE_IOCTL_DBG(xe, (xe_vma_start(vma) != addr ||
 				 xe_vma_end(vma) != addr + range) && !async))

total: 0 errors, 2 warnings, 1 checks, 1207 lines checked




More information about the Intel-xe mailing list