[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: switch to using drm_exec

[Patchwork]

== Series Details ==

Series: drm/xe: switch to using drm_exec
URL   : https://patchwork.freedesktop.org/series/120632/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6e13c4a43eefe33042e7d093d1d5744e267c9707
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Wed Jul 12 16:37:40 2023 +0000

    drm/xe: switch to using drm_exec
    
    Replace the use of ttm_execbuf_util helpers with the drm_exec helpers.
    
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch d39e49e2ad386bf59f585a05ab659563e0472314 drm-intel
89485e480 drm: execution context for GEM buffers v5
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:17: WARNING:TYPO_SPELLING: 'unecessary' may be misspelled - perhaps 'unnecessary'?
#17: 
    overhead is unecessary and measurable.
                ^^^^^^^^^^

-:80: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#80: 
new file mode 100644

-:85: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/drm_exec.c', please use '//' instead
#85: FILE: drivers/gpu/drm/drm_exec.c:1:
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */

-:85: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#85: FILE: drivers/gpu/drm/drm_exec.c:1:
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */

-:135: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#135: FILE: drivers/gpu/drm/drm_exec.c:51:
+#define DRM_EXEC_DUMMY (void*)~0

-:135: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#135: FILE: drivers/gpu/drm/drm_exec.c:51:
+#define DRM_EXEC_DUMMY (void*)~0

-:349: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#349: FILE: drivers/gpu/drm/drm_exec.c:265:
+
+	}

-:440: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#440: FILE: include/drm/drm_exec.h:20:
+	uint32_t		flags;

-:481: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'exec' - possible side-effects?
#481: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:481: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#481: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:481: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#481: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:512: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#512: FILE: include/drm/drm_exec.h:92:
+#define drm_exec_retry_on_contention(exec)		\
+	if (unlikely(drm_exec_is_contended(exec)))	\
+		goto *__drm_exec_retry_ptr

-:512: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#512: FILE: include/drm/drm_exec.h:92:
+#define drm_exec_retry_on_contention(exec)		\
+	if (unlikely(drm_exec_is_contended(exec)))	\
+		goto *__drm_exec_retry_ptr

-:540: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <ckoenig.leichtzumerken at gmail.com>' != 'Signed-off-by: Christian König <christian.koenig at amd.com>'

total: 3 errors, 6 warnings, 5 checks, 488 lines checked
6e13c4a43 drm/xe: switch to using drm_exec