[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Code cleanup

[Patchwork]

== Series Details ==

Series: drm/xe: Code cleanup
URL   : https://patchwork.freedesktop.org/series/120684/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1e4448730d14b62a7ae2d2a4b169674cb85d44f6
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Thu Jul 13 15:06:11 2023 +0000

    drm/xe: Fix typos
    
    Fix minor issues: remove extra ';' and s/Initialise/Initialize/.
    
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch 17d3e3fbeb4ee15f7b89cedff2d1f2662dffbf97 drm-intel
f28501b6f drm/xe: Cleanup SPACING style issues
-:21: WARNING:LONG_LINE: line length of 117 exceeds 100 columns
#21: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:97:
+#define IS_DISPLAY_STEP(xe, first, last) ({u8 __step = (xe)->info.step.display; first <= __step && __step <= last; })

-:21: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'first' may be better as '(first)' to avoid precedence issues
#21: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:97:
+#define IS_DISPLAY_STEP(xe, first, last) ({u8 __step = (xe)->info.step.display; first <= __step && __step <= last; })

-:21: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#21: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:97:
+#define IS_DISPLAY_STEP(xe, first, last) ({u8 __step = (xe)->info.step.display; first <= __step && __step <= last; })

-:22: WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#22: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:98:
+#define IS_GRAPHICS_STEP(xe, first, last) ({u8 __step = (xe)->info.step.graphics; first <= __step && __step <= last; })

-:22: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'first' may be better as '(first)' to avoid precedence issues
#22: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:98:
+#define IS_GRAPHICS_STEP(xe, first, last) ({u8 __step = (xe)->info.step.graphics; first <= __step && __step <= last; })

-:22: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#22: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:98:
+#define IS_GRAPHICS_STEP(xe, first, last) ({u8 __step = (xe)->info.step.graphics; first <= __step && __step <= last; })

-:83: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 13)
#83: FILE: drivers/gpu/drm/xe/xe_gt.h:15:
 	for ((id__) = 0; (id__) < ARRAY_SIZE((gt__)->hw_engines); (id__)++) \
+	     for_each_if(((hwe__) = (gt__)->hw_engines + (id__)) && \

-:143: WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#143: FILE: drivers/gpu/drm/xe/xe_rtp.h:376:
+	struct xe_hw_engine * :	(struct xe_rtp_process_ctx){ { (void *)(arg__) }, XE_RTP_PROCESS_TYPE_ENGINE },	\

-:144: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#144: FILE: drivers/gpu/drm/xe/xe_rtp.h:377:
+	struct xe_gt * :	(struct xe_rtp_process_ctx){ { (void *)(arg__) }, XE_RTP_PROCESS_TYPE_GT })

-:158: ERROR:SPACING: space required after that ',' (ctx:VxB)
#158: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:17:
+#define _XE_COUNT_ARGS(...) _XE_ESC(__XE_COUNT_ARGS(__VA_ARGS__, 5, 4, 3, 2, 1,))
                                                                               ^

-:175: WARNING:LONG_LINE: line length of 126 exceeds 100 columns
#175: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_FOREACH(prefix_, sep_, args_) _XE_ESC(_XE_RTP_CONCAT(PASTE_, _XE_COUNT_ARGS args_)(prefix_, sep_, args_))

-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#175: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_FOREACH(prefix_, sep_, args_) _XE_ESC(_XE_RTP_CONCAT(PASTE_, _XE_COUNT_ARGS args_)(prefix_, sep_, args_))

total: 1 errors, 6 warnings, 5 checks, 139 lines checked
4d9cfb5de drm/xe: Cleanup OPEN_BRACE style issues
cb25af6c9 drm/xe: Cleanup POINTER_LOCATION style issues
b4229b375 drm/xe: Cleanup CODE_INDENT style issues
a272a7007 drm/xe: Cleanup TRAILING_WHITESPACE style issues
ea524e5b0 drm/xe: Cleanup COMPLEX_MACRO style issues
1e4448730 drm/xe: Fix typos