[Intel-xe] ✗ CI.checkpatch: warning for xe_device_mem_access fixes and related bits (rev4)

[Patchwork]

== Series Details ==

Series: xe_device_mem_access fixes and related bits (rev4)
URL   : https://patchwork.freedesktop.org/series/119213/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 551386053c5f5f72605f02b2579201fa4f1ab7a4
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Jul 17 12:25:13 2023 +0100

    drm/xe: add lockdep annotation for xe_device_mem_access_get()
    
    The atomics here might hide potential issues, also rpm core is not
    holding any lock when calling our rpm resume callback, so add a dummy lock
    with the idea that xe_pm_runtime_resume() is eventually going to be
    called when we are holding it. This only needs to happen once and then
    lockdep can validate all callers and their locks.
    
    v2: (Thomas Hellström)
     - Prefer static lockdep_map instead of full blown mutex.
    
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Acked-by: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 71340f700edfaa0cdc35eab8f3c563c44c0a6ca1 drm-intel
654080b43 drm/xe: fix xe_device_mem_access_get() races
-:80: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "xe_pm_read_callback_task"
#80: FILE: drivers/gpu/drm/xe/xe_device.c:417:
+	if (xe_pm_read_callback_task(xe) != NULL)

-:218: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!xe_pm_read_callback_task"
#218: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1055:
+	if (!ongoing && xe_pm_read_callback_task(ct_to_xe(ct)) == NULL)

-:264: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!xe_pm_read_callback_task"
#264: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1125:
+	if (!ongoing && xe_pm_read_callback_task(ct_to_xe(ct)) == NULL)

total: 0 errors, 0 warnings, 3 checks, 318 lines checked
adc44bf43 drm/xe/vm: tidy up xe_runtime_pm usage
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: Oded Gabbay <ogabbay at kernel.org>
Signed-off-by: Matthew Auld <matthew.auld at intel.com>

total: 0 errors, 1 warnings, 0 checks, 30 lines checked
2dd1d6d0b drm/xe/debugfs: grab mem_access around forcewake
d007f19f5 drm/xe/guc_pc: add missing mem_access for freq_rpe_show
91b6a4775 drm/xe/mmio: grab mem_access in xe_mmio_ioctl
6b0604c02 drm/xe: ensure correct access_put ordering
c4d0382a7 drm/xe: drop xe_device_mem_access_get() from guc_ct_send
f8d1d3642 drm/xe/ggtt: prime ggtt->lock against FS_RECLAIM
fa3109913 drm/xe: drop xe_device_mem_access_get() from invalidation_vma
551386053 drm/xe: add lockdep annotation for xe_device_mem_access_get()