[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: switch to using drm_exec

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 17 13:22:28 UTC 2023


== Series Details ==

Series: drm/xe: switch to using drm_exec
URL   : https://patchwork.freedesktop.org/series/120842/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5c8c4d07724d199a6127cc7fe166c7326b2ea26a
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Mon Jul 17 13:16:43 2023 +0000

    drm/xe: switch to using drm_exec
    
    Replace the use of ttm_execbuf_util helpers with the drm_exec helpers.
    
    v2:
    - Call dma-resv locking functions directly in xe_bo_lock and
      xe_vm_lock functions (Matthew Brost)
    - Switch to execution context for GEM buffers v7 (Christian König)
    - Use DRM_EXEC_INTERRUPTIBLE_WAIT
    v3:
    - Only call dma_resv_reserve_fences if at least one fence needs to
      be reserved (Christian König and Matthew Brost)
    
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch 71340f700edfaa0cdc35eab8f3c563c44c0a6ca1 drm-intel
2f9b7b020 drm: execution context for GEM buffers v7
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:87: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#87: 
new file mode 100644

-:359: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#359: FILE: drivers/gpu/drm/drm_exec.c:268:
+
+	}

-:450: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#450: FILE: include/drm/drm_exec.h:20:
+	uint32_t		flags;

-:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'exec' - possible side-effects?
#491: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#491: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#491: FILE: include/drm/drm_exec.h:61:
+#define drm_exec_for_each_locked_object(exec, index, obj)	\
+	for (index = 0, obj = (exec)->objects[0];		\
+	     index < (exec)->num_objects;			\
+	     ++index, obj = (exec)->objects[index])

-:523: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#523: FILE: include/drm/drm_exec.h:93:
+#define drm_exec_retry_on_contention(exec)			\
+	do {							\
+		if (unlikely(drm_exec_is_contended(exec)))	\
+			goto *__drm_exec_retry_ptr;		\
+	} while (0)

total: 0 errors, 2 warnings, 5 checks, 494 lines checked
5c8c4d077 drm/xe: switch to using drm_exec




More information about the Intel-xe mailing list