[Intel-xe] ✗ CI.checkpatch: warning for xe_bo selftest fixes (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 18 10:46:49 UTC 2023


== Series Details ==

Series: xe_bo selftest fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/120849/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2ab611547cb164df57e9bf78c092acaf8986b788
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Jul 17 14:32:04 2023 +0100

    drm/xe: add missing bulk_move reset
    
    It looks like bulk_move is set during object construction, but is only
    removed on object close, however in various places we might not yet have
    an actual fd to close, like on the error paths for the gem_create ioctl,
    and also one internal user for the evict_test_run_gt() selftest. Try to
    handle those cases by manually resetting the bulk_move. This should
    prevent triggering:
    
    WARNING: CPU: 7 PID: 8252 at drivers/gpu/drm/ttm/ttm_bo.c:327
    ttm_bo_release+0x25e/0x2a0 [ttm]
    
    v2 (Nirmoy):
      - It should be safe to just unconditionally call __xe_bo_unset_bulk_move().
    
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>
+ /mt/dim checkpatch a43fd52b7ab2009631518ead5ca0afe9bc44515a drm-intel
49aa1eddc drm/xe/selftests: hold rpm for evict_test_run_device()
8d88d18e7 drm/xe/selftests: hold rpm for ccs_test_migrate()
f90c8166d drm/xe/selftests: restart GT after xe_bo_restore_kernel()
2ab611547 drm/xe: add missing bulk_move reset
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
  - It should be safe to just unconditionally call __xe_bo_unset_bulk_move().

total: 0 errors, 1 warnings, 0 checks, 75 lines checked




More information about the Intel-xe mailing list