[Intel-xe] [PATCH] drm/xe: Cleanup style warnings

[Lucas De Marchi]

On Mon, Jul 17, 2023 at 07:37:46PM +0000, Francois Dugast wrote:
>diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
>index f16de5ec0586..aeeac05bb8bb 100644
>--- a/drivers/gpu/drm/xe/xe_vm.c
>+++ b/drivers/gpu/drm/xe/xe_vm.c
>@@ -2105,16 +2105,20 @@ static int vm_bind_ioctl_lookup_vma(struct xe_vm *vm, struct xe_bo *bo,
> 	case XE_VM_BIND_OP_PREFETCH:
> 		vma = xe_vm_find_overlapping_vma(vm, addr, range);
> 		if (XE_IOCTL_DBG(xe, !vma))
>-			return -ENODATA;	/* Not an actual error, IOCTL
>-						   cleans up returns and 0 */
>+			return -ENODATA;	/*
>+						 * Not an actual error, IOCTL
>+						 * cleans up returns and 0
>+						 */

I think this  change and the one below makes it even more unreadable.
It'd be much better to just bring the comment at their usual place, just
before what it's commenting on

  	case XE_VM_BIND_OP_PREFETCH:
  		vma = xe_vm_find_overlapping_vma(vm, addr, range);
  		if (XE_IOCTL_DBG(xe, !vma))
			/* Not an actual error: IOCTL cleans up the return */
			return -ENODATA;

Lucas De Marchi

> 		if (XE_IOCTL_DBG(xe, (xe_vma_start(vma) != addr ||
> 				      xe_vma_end(vma) != addr + range) && !async))
> 			return -EINVAL;
> 		break;
> 	case XE_VM_BIND_OP_UNMAP_ALL:
> 		if (XE_IOCTL_DBG(xe, list_empty(&bo->ttm.base.gpuva.list)))
>-			return -ENODATA;	/* Not an actual error, IOCTL
>-						   cleans up returns and 0 */
>+			return -ENODATA;	/*
>+						 * Not an actual error, IOCTL
>+						 * cleans up returns and 0
>+						 */
> 		break;
> 	default:
> 		XE_BUG_ON("NOT POSSIBLE");