[Intel-xe] ✗ CI.checkpatch: warning for Remove uses of BUG_ON

Patchwork patchwork at emeril.freedesktop.org
Fri Jul 21 13:34:16 UTC 2023


== Series Details ==

Series: Remove uses of BUG_ON
URL   : https://patchwork.freedesktop.org/series/121125/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7cbc7520db27f221b72e59ea782b27215447b270
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Fri Jul 21 13:20:30 2023 +0000

    drm/xe: Remove uses of BUG_ON
    
    BUG_ON is for when the code should stop and not execute further because
    something went terribly wrong. This is not the case in many existing
    uses, where recovery should be intended and BUG_ON is now replaced
    with drm_err().
    
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch 786d2a4f30e168368b4d19d3e1d2f57d18ebecf8 drm-intel
7cbc7520d drm/xe: Remove uses of BUG_ON
-:568: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#568: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:401:
+	if (!xe_engine_is_parallel(e)) {
+	drm_err(&gt_to_xe(e->gt)->drm, "!xe_engine_is_parallel(e)");

-:651: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#651: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:681:
+	if ((engine_destroyed(e) || engine_pending_disable(e)) && !engine_banned(e) && !engine_suspended(e)) {

total: 0 errors, 2 warnings, 0 checks, 1166 lines checked




More information about the Intel-xe mailing list