[Intel-xe] [PATCH 2/2] drm/xe: xe_engine_create_ioctl should check gt_count, not tile_count

Lucas De Marchi lucas.demarchi at intel.com
Sat Jul 22 02:01:59 UTC 2023


On Fri, Jul 21, 2023 at 10:55:59AM -0700, Matt Roper wrote:
>Platforms like MTL only have a single tile, but multiple GTs.
>Ensure XE_ENGINE_CREATE accepts engine creation on gt1 on such
>platforms.
>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_engine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c
>index 59e0a9e085ba..0102dad16e29 100644
>--- a/drivers/gpu/drm/xe/xe_engine.c
>+++ b/drivers/gpu/drm/xe/xe_engine.c
>@@ -416,7 +416,7 @@ find_hw_engine(struct xe_device *xe,
> 	if (eci.engine_class > ARRAY_SIZE(user_to_xe_engine_class))
> 		return NULL;
>
>-	if (eci.gt_id >= xe->info.tile_count)
>+	if (eci.gt_id >= xe->info.gt_count)
> 		return NULL;
>
> 	idx = array_index_nospec(eci.engine_class,
>@@ -539,7 +539,7 @@ int xe_engine_create_ioctl(struct drm_device *dev, void *data,
> 	if (XE_IOCTL_DBG(xe, err))
> 		return -EFAULT;
>
>-	if (XE_IOCTL_DBG(xe, eci[0].gt_id >= xe->info.tile_count))
>+	if (XE_IOCTL_DBG(xe, eci[0].gt_id >= xe->info.gt_count))
> 		return -EINVAL;
>
> 	if (eci[0].engine_class == DRM_XE_ENGINE_CLASS_VM_BIND) {
>-- 
>2.41.0
>


More information about the Intel-xe mailing list