[Intel-xe] [PATCH v2 2/2] drm/xe/pmu: Enable PMU interface

[Iddamsetty, Aravind]

On 22-07-2023 20:09, Dixit, Ashutosh wrote:
> On Tue, 27 Jun 2023 05:21:13 -0700, Aravind Iddamsetty wrote:
>>
>> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>> index 2458397ce8af..96e3720923d4 100644
>> --- a/drivers/gpu/drm/xe/xe_gt.c
>> +++ b/drivers/gpu/drm/xe/xe_gt.c
>> @@ -593,6 +593,8 @@ int xe_gt_suspend(struct xe_gt *gt)
>> 	if (err)
>> 		goto err_msg;
>>
>> +	engine_group_busyness_store(gt);
>> +
>> 	err = xe_uc_suspend(&gt->uc);
>> 	if (err)
>> 		goto err_force_wake;
> 
> Also, another tiny point, let's not call engine_group_busyness_store
> directly from here. Let's expose a xe_pmu_suspend() in xe_pmu.h and call
> that from here and have xe_pmu_suspend call engine_group_busyness_store.

Ok makes sense.

Thanks,
Aravind.