[Intel-xe] ✓ CI.checkpatch: success for drm/xe: add lockdep annotation for xe_device_mem_access_put() (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Mon Jul 24 10:50:30 UTC 2023
== Series Details ==
Series: drm/xe: add lockdep annotation for xe_device_mem_access_put() (rev2)
URL : https://patchwork.freedesktop.org/series/121119/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d28161b375947964370145533d6d6546860fbf8d
Author: Matthew Auld <matthew.auld at intel.com>
Date: Mon Jul 24 11:47:44 2023 +0100
drm/xe: add lockdep annotation for xe_device_mem_access_put()
The main motivation is with d3cold which will make the suspend and
resume callbacks even more scary, but is useful regardless. We already
have the needed annotation on the acquire side with
xe_device_mem_access_get(), and by adding the annotation on the release
side we should have a lot more confidence that our locking hierarchy is
correct.
v2:
- Move the annotation into both callbacks for better symmetry. Also
don't hold over the entire mem_access_get(); we only need to lockep
to understand what is being held upon entering mem_access_get(), and
how that matches up with locks in the callbacks.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Anshuman Gupta <anshuman.gupta at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch f7e68e5db4417dde38c45cc8aedd7cb2b18fa678 drm-intel
d28161b37 drm/xe: add lockdep annotation for xe_device_mem_access_put()
More information about the Intel-xe
mailing list