[Intel-xe] [PATCH v7 3/3] fault-inject: Include linux/types.h by default.

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Tue Jul 25 15:13:17 UTC 2023



> -----Original Message-----
> From: Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>
> Sent: 25 July 2023 20:40
> To: intel-xe at lists.freedesktop.org
> Cc: Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>; De Marchi,
> Lucas <lucas.demarchi at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>;
> Nilawar, Badal <badal.nilawar at intel.com>
> Subject: [PATCH v7 3/3] fault-inject: Include linux/types.h by default.
> 
> Functions should_fail_alloc_page, should_failslab, and __should_failslab are
> declared irrespective of CONFIG_FAULT_INJECTION. These functions use bool
> and gfp_t types, which are treated as unknown when
> CONFIG_FAULT_INJECTION is disabled because the inclusion of linux/types.h is
> missing.
> 
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Badal Nilawar <badal.nilawar at intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> ---
>  include/linux/fault-inject.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h index
> 481abf530b3c..f83ab2b6cd08 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -2,9 +2,10 @@
>  #ifndef _LINUX_FAULT_INJECT_H
>  #define _LINUX_FAULT_INJECT_H
> 
> +#include <linux/types.h>
> +
>  #ifdef CONFIG_FAULT_INJECTION
> 
> -#include <linux/types.h>
>  #include <linux/debugfs.h>
>  #include <linux/configfs.h>
>  #include <linux/ratelimit.h>
> --
> 2.25.1



More information about the Intel-xe mailing list